fix: equality comparison for semantic version when number of segments = max allowed segments by Namyalg · Pull Request #2794 · firebase/firebase-admin-node
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Testing
- Make sure all existing tests in the repository pass after your change [Verified all existing tests pass]
- If you fixed a bug or added a feature, add a new test to cover your code [Unit tests added]
Fixes #2793
Namyalg
changed the title
fix: equality comparison for semantic version comparison when number of segments = max allowed segments
fix: equality comparison for semantic version when number of segments = max allowed segments
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters