chore: Add firebaseAdminVersion to Firestore settings by jonathanedey · Pull Request #2795 · firebase/firebase-admin-node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jonathanedey

Copy link

Collaborator

@jonathanedey jonathanedey commented

Dec 2, 2024

edited

Loading

  • Set firebaseAdminVersion in Firestore setting to append fire-admin tag to x-goog-api-client.
  • Bump @google-cloud/firestore to v7.11.0

This is dependent on googleapis/nodejs-firestore#2238 which is available in @google-cloud/firestore v7.11.0 but does not break previous versions.

@jonathanedey jonathanedey marked this pull request as ready for review

December 3, 2024 15:13
Copy link

Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonathan!

@jonathanedey jonathanedey merged commit 69d6494 into master

Dec 5, 2024

@jonathanedey jonathanedey deleted the je-fs-header branch

December 5, 2024 19:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanedey @lahirumaramba