chore: Fix strip-only mode issues in Node.js 22.18 by lahirumaramba · Pull Request #2958 · firebase/firebase-admin-node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@lahirumaramba

Copy link

Member

@lahirumaramba lahirumaramba commented

Aug 12, 2025

edited

Loading

It appears that the strip-only mode is enabled by default in Node 22.18 when using mocha --require ts-node/register.
Upgrading to mocha v11 seems to resolve the issue.

@lahirumaramba lahirumaramba added the release:stage

Stage a release candidate

label

Aug 12, 2025

@lahirumaramba lahirumaramba changed the title chore: Fix import syntax issue in Node.js 22.x chore: Fix strip-only mode issues in Node.js 22.18

Aug 13, 2025

@lahirumaramba lahirumaramba removed the release:stage

Stage a release candidate

label

Aug 13, 2025

@lahirumaramba lahirumaramba added the release:stage

Stage a release candidate

label

Aug 13, 2025
Copy link

Collaborator

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lahirumaramba lahirumaramba merged commit be214b4 into master

Aug 18, 2025

12 of 14 checks passed

@lahirumaramba lahirumaramba deleted the lm-fix-node22 branch

August 18, 2025 20:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanedey jonathanedey jonathanedey approved these changes

Labels

release:stage

Stage a release candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lahirumaramba @jonathanedey