Home Original page

fix: upgrade @google-cloud/storage@7.19.0 by lahirumaramba · Pull Request #3071 · firebase/firebase-admin-node

Summary of Changes

Hello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's security posture and maintaining compatibility with modern development standards. It primarily addresses a known security vulnerability by updating a key optional dependency and simultaneously upgrades the TypeScript version, necessitating minor code adjustments to conform to stricter type-checking rules. These changes ensure the project remains secure and aligned with current best practices.

Highlights

  • Security Fix: Upgraded the optional @google-cloud/storage dependency from ^7.14.0 to ^7.19.0 to mitigate a security vulnerability found in its underlying dependency, fast-xml-parser.
  • TypeScript Update: Bumped the typescript dev dependency from 5.5.4 to ^5.7.3 to support newer compilation requirements. This also involved refactoring type assertions in src/utils/api-request.ts to satisfy stricter type-checking.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package-lock.json
    • Updated firebase-admin to version 13.7.0.
    • Updated typescript dev dependency to 5.9.3.
    • Updated @google-cloud/storage optional dependency to 7.19.0.
    • Updated fast-xml-parser to 5.3.5.
    • Updated strnum to 2.1.2.
    • Adjusted the dependency range for @google-cloud/promisify within @google-cloud/storage.
    • Removed PayPal funding URL for fast-xml-parser.
    • Added GitHub funding URL for strnum.
  • package.json
    • Updated firebase-admin to version 13.7.0.
    • Updated @google-cloud/storage optional dependency to ^7.19.0.
    • Updated typescript dev dependency to ^5.7.3.
  • src/utils/api-request.ts
    • Refactored non-null assertions for this.options.headers to explicit type assertions (as http.OutgoingHttpHeaders) in AsyncHttpCall and AsyncHttp2Call classes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩