fix FcmErrorCode error type by chemidy · Pull Request #391 · firebase/firebase-admin-node

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

hiranya911 merged 2 commits intofirebase:masterfrom

chemidy:FcmError

Nov 15, 2018

Merged

fix FcmErrorCode error type#391

hiranya911 merged 2 commits intofirebase:masterfrom

chemidy:FcmError

Conversation

@chemidy

Copy link

Contributor

@chemidy chemidy commented

Nov 15, 2018

already fixed on firebase-admin-go

Copy link

Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @chemidy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chemidy @hiranya911