add subtitle in messaging.ApsAlert payload by chemidy · Pull Request #393 · firebase/firebase-admin-node
Navigation Menu
{{ message }}
firebase / firebase-admin-node Public
- Notifications You must be signed in to change notification settings
- Fork 418
Merged
add subtitle in messaging.ApsAlert payload#393
hiranya911 merged 3 commits intofirebase:masterfrom
chemidy:aps-subtitle
add subtitle in messaging.ApsAlert payload#393
hiranya911 merged 3 commits intofirebase:masterfrom
chemidy:aps-subtitle
Conversation
chemidy added 2 commits
November 21, 2018 13:28hiranya911 suggested changes Nov 21, 2018
Copy link
Contributor
hiranya911
left a comment
hiranya911
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one change suggested.
src/messaging/messaging.ts
Outdated
Show resolved
Hide resolved
src/messaging/messaging.ts Outdated Show resolved Hide resolved
hiranya911
self-assigned this
hiranya911 approved these changes Nov 27, 2018
Copy link
Contributor
hiranya911
left a comment
hiranya911
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hiranya911
merged commit
48ac9d5
into
firebase:master
chemidy
deleted the
aps-subtitle
branch
snyk-bot
mentioned this pull request
snyk-bot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants