feat(fcm): Added support for specifying the analytics label for notifications. by chemidy · Pull Request #597 · firebase/firebase-admin-node
- add analytics_label
FR:analytics_label support in FCM #580
Cyrille Hemidy added 2 commits
July 20, 2019 12:37Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some style comments. Thanks for the PR!
Cyrille Hemidy added 3 commits
July 23, 2019 10:14Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.d.ts content looks good, thanks chemidy!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need some test cases for the new validators.
And I'm also waiting to hear from the FCM team about fcmOptions vs fcm_options in the JSON payload.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hiranya911
changed the title
Analytics label
feat(fcm): Added support for specifying the analytics label for notifications.
This was referenced
Nov 13, 2019This was referenced
Mar 10, 2020This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters