add channel_id to messaging.AndroidNotification by chemidy · Pull Request #227 · firebase/firebase-admin-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

hiranya911 merged 5 commits intofirebase:masterfrom

chemidy:channel-id

Dec 1, 2018

Merged

add channel_id to messaging.AndroidNotification#227

hiranya911 merged 5 commits intofirebase:masterfrom

chemidy:channel-id

Conversation

@chemidy

Copy link Copy Markdown

Contributor

@chemidy chemidy commented

Dec 1, 2018

add channel_id to messaging.AndroidNotification #151

Copy link Copy Markdown

Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @chemidy

@hiranya911 hiranya911 self-assigned this

Dec 1, 2018

@hiranya911 hiranya911 merged commit 92652ff into firebase:master

Dec 1, 2018
Copy link Copy Markdown

@patttydadd patttydadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@patttydadd patttydadd patttydadd left review comments

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemidy @hiranya911 @patttydadd