feat(fcm): Added support for sending an image URL in notifications by cchamm · Pull Request #332

feat(fcm): Added support for sending an image URL in notifications by cchamm · Pull Request #332 · firebase/firebase-admin-python

Cham and others added 5 commits

August 21, 2019 12:01

Hi @cchamm. Currently swamped with a couple of pending releases. Will take a look at this shortly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just need one addition.

		def __init__(self, title=None, body=None, icon=None, color=None, sound=None, tag=None,
		click_action=None, body_loc_key=None, body_loc_args=None, title_loc_key=None,
		title_loc_args=None, channel_id=None):
		title_loc_args=None, channel_id=None, image=None):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cham and others added 3 commits

September 10, 2019 12:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

hiranya911 changed the title ~~Add "image" field to AndroidNotification and Notification~~ feat(fcm): Added support for sending an image URL in notifications

Sep 10, 2019