fix(fcm): Declare `send_each` and `send_each_for_multicast` in `__all__` by MarcoTomasRodriguez · Pull Request #749 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
lahirumaramba merged 1 commit intofirebase:masterfrom
Jan 3, 2024Merged
fix(fcm): Declare send_each and send_each_for_multicast in __all__#749
lahirumaramba merged 1 commit intofirebase:masterfrom
fix(fcm): Declare send_each and send_each_for_multicast in __all__#749
lahirumaramba merged 1 commit intofirebase:masterfrom
Conversation
Copy link Copy Markdown
Contributor
MarcoTomasRodriguez
commented
Dec 22, 2023
MarcoTomasRodriguez
commented
The new send_each and send_each_for_multicast functions were not declared on __all__ (although they belong to the public API), showing some warnings on popular linters. This PR complements #706.
lahirumaramba approved these changes Jan 3, 2024
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MarcoTomasRodriguez for your contribution! LGTM
lahirumaramba
self-assigned this
lahirumaramba
merged commit
b2173da
into
firebase:master
lahirumaramba
added
the
release-note
label
jonathanedey pushed a commit that referenced this pull request
Feb 13, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment