chore: Correct `x-goog-api-client` header logic by jonathanedey · Pull Request #876 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
chore: Correct x-goog-api-client header logic#876
lahirumaramba merged 1 commit intomasterfrom
chore: Correct x-goog-api-client header logic#876
lahirumaramba merged 1 commit intomasterfrom
Conversation
Copy link Copy Markdown
Collaborator
jonathanedey
commented
May 1, 2025
jonathanedey
commented
- Lower cased
x-goog-api-client - Moved
x-goog-api-clientto be applied on request rather that on session - Fixed tests to simulate
x-goog-api-clientmutation byAuthorizedSession
jonathanedey
requested a review
from lahirumaramba
jonathanedey
assigned
lahirumaramba
lahirumaramba approved these changes May 8, 2025
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! LGTM!
lahirumaramba
deleted the
je-fix-metrics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment