Home Original page

Update to c++ 17 by AustinBenoit · Pull Request #1837 · firebase/firebase-cpp-sdk

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's build configuration by upgrading the required C++ standard from C++14 to C++17. This change allows the codebase to leverage newer language features and improvements available in C++17, potentially enhancing code quality, performance, and developer productivity. The update is applied consistently across the main project and all integration test modules.

Highlights

  • C++ Standard Update: The project's C++ standard has been updated from C++14 to C++17 across all relevant CMakeLists.txt files, including the main project, integration tests for various Firebase services (Analytics, App, App Check, Auth, Database, Firestore, Functions, Installations, Messaging, Remote Config, Storage, UMP), and the testing module.
  • Build Configuration: All CMake configurations now explicitly require C++17, preventing fallback to earlier versions, ensuring consistency in the build environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • analytics/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • app/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • app/rest/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • app_check/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • auth/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • database/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • firestore/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • firestore/integration_test_internal/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • functions/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • installations/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • messaging/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • remote_config/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • storage/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • testing/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
  • ump/integration_test/CMakeLists.txt
    • Updated CMAKE_CXX_STANDARD from 14 to 17.
Activity
  • The author, AustinBenoit, has initiated testing across desktop, iOS, and Android platforms to validate the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩