Fix the logic to generate .pro file by cynthiajoan · Pull Request #664 · firebase/firebase-cpp-sdk
Navigation Menu
{{ message }}
firebase / firebase-cpp-sdk Public
- Notifications You must be signed in to change notification settings
- Fork 137
Merged
Fix the logic to generate .pro file#664
DellaBitta merged 4 commits intomainfrom
Fix the logic to generate .pro file#664
DellaBitta merged 4 commits intomainfrom
Conversation
cynthiajoan
requested a review
from a-maurice
google-cla
bot
added
the
cla: yes
label
a-maurice approved these changes Sep 15, 2021
DellaBitta requested changes Sep 15, 2021
Copy link Copy Markdown
Contributor
DellaBitta
left a comment
•
edited
Loading
DellaBitta
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release notes should be under 8.5.0.
You should merge main into your branch first to see the 8.5.0 release notes header in your branch.
Copy link Copy Markdown
Contributor Author
cynthiajoan
commented
Sep 15, 2021
cynthiajoan commented
Sep 15, 2021Can you update the release notes please?
Updated
Cynthia Jiang added 2 commits
September 15, 2021 10:49DellaBitta approved these changes Sep 15, 2021
cynthiajoan
added
the
tests-requested: quick
label
Sep 15, 2021
github-actions
bot
added
tests: in-progress
and removed tests-requested: quick
Trigger a quick set of integration tests.labels
Sep 15, 2021
Copy link Copy Markdown
❌ Integration test FAILED
Requested by @DellaBitta on commit 2008044
Last updated: Wed Sep 15 15:41 PDT 2021
View integration test log & download artifacts
| Failures | Configs |
|---|---|
| messaging | [TEST] [ERROR] [Android] [All os] [android_target] |
Add flaky tests to go/fpl-cpp-flake-tracker
firebase-workflow-trigger
bot
removed
the
tests: in-progress
label
Sep 15, 2021
DellaBitta
merged commit
2008044
into
main
DellaBitta
deleted the
feature/rc_rest_update
branch
github-actions
bot
added
tests: in-progress
and removed tests: failed
This PR's integration tests failed.labels
Sep 15, 2021
firebase-workflow-trigger
bot
removed
the
tests: in-progress
label
Sep 15, 2021
firebase
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.