Properly convert milliseconds to seconds by pawelsnk · Pull Request #767 · firebase/firebase-cpp-sdk

@pawelsnk

Currently, a value expressed in milliseconds is directly assigned to a variable
which is supposed to store seconds and it's later converted to mills again.
Thus, convert properly upon assignment

cynthiajoan

@pawelsnk

@pawelsnk

jonsimantov

@pawelsnk

@pawelsnk

jonsimantov

@pawelsnk pawelsnk deleted the fix-config-expiration-cache-fetch-and-activate branch

December 2, 2021 07:47

jonsimantov added a commit that referenced this pull request

Dec 4, 2021
* Fix link in readme (#768)

* update test devices (#757)

* Timeout and Retry FTL failures and mark flakiness

* Update C++ SDK version to 8.8.0.

* Add Analytics header update to iOS SDK update. (#775)

* Add Analytics header update to iOS SDK update.

* Update Android dependencies - Wed Dec 01 2021 (#773)

### Android

- com.google.firebase.firebase_database → 20.0.3
- com.google.firebase.firebase_perf → 20.0.4

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903).

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>

* Fix typo in log output.

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support. (#774)

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support.

* Fix integration tests workflow to respect xcode_version in matrix.

* Add extra newline to header comment.

* Update iOS dependencies - Thu Dec 02 2021 (#779)

* Update iOS dependencies - Thu Dec 02 2021

### iOS

- Firebase/Analytics → 8.10.0
- Firebase/Auth → 8.10.0
- Firebase/Core → 8.10.0
- Firebase/Crashlytics → 8.10.0
- Firebase/Database → 8.10.0
- Firebase/DynamicLinks → 8.10.0
- Firebase/Firestore → 8.10.0
- Firebase/Functions → 8.10.0
- Firebase/Installations → 8.10.0
- Firebase/Messaging → 8.10.0
- Firebase/RemoteConfig → 8.10.0
- Firebase/Storage → 8.10.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697).

* Add missing copyright lines.

* Add Firestore release note.

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>

* Properly convert milliseconds to seconds (#767)

* Properly convert milliseconds to seconds

Currently, a value expressed in milliseconds is directly assigned to a variable
which is supposed to store seconds and it's later converted to mills again.
Thus, convert properly upon assignment

* Update readme.md

* Change LogDebug to NSLog in app's swizzling code. (#783)

* Change LogDebug to NSLog.

* Change log message.

* Add comment.

* Add copyright line when importing Analytics iOS headers, if missing (#780)

* Add copyright line to iOS headers

* Make copyright conditional to whether the file already has one.

* Also set Xcode version explicitly in Android workflow. (#786)

* Timeout & retry "install integration test deps" step (#785)

* Format code.

Co-authored-by: Борис Рязанцев <88411548+borisssoft@users.noreply.github.com>
Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: pawelsnk <pawelsnk@o2.pl>

@firebase firebase locked and limited conversation to collaborators

Jan 2, 2022