Add check to let Windows Terminal pass by uyha · Pull Request #6999 · fish-shell/fish-shell
Navigation Menu
{{ message }}
fish-shell / fish-shell Public
- Notifications You must be signed in to change notification settings
- Fork 2.3k
Closed
Add check to let Windows Terminal pass#6999
uyha wants to merge 1 commit intofish-shell:masterfrom
uyha:master
Add check to let Windows Terminal pass#6999
uyha wants to merge 1 commit intofish-shell:masterfrom
uyha:master
Conversation
Copy link Copy Markdown
Contributor
uyha
commented
May 12, 2020
uyha
commented
Description
Because Windows Terminal sets the $WT_PROFILE_ID, use it to let the terminal use fish_vi_cursor function.
Fixes issue #
TODOs:
- Changes to fish usage are reflected in user documentation/manpages.
- Tests have been added for regressions fixed
- User-visible changes noted in CHANGELOG.md
Copy link Copy Markdown
Member
ridiculousfish
commented
May 15, 2020
ridiculousfish commented
May 15, 2020Merged as 76bbcb9 . Thank you!
ridiculousfish
closed this
ridiculousfish
added this to the
fish 3.2.0 milestone
ridiculousfish
self-assigned this
ridiculousfish
added
the
vi-mode
label
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.