[Linux] Return keyboard pressed state by bleroux · Pull Request #42346 · flutter/engine
This was referenced
Jun 12, 2023auto-submit bot pushed a commit that referenced this pull request
Jun 21, 2023## Description This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). This is a rework of #41695 which was reverted in #42346. This issue with #41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see flutter/flutter#122441 (comment) for a repro). This PR fixes this issue by changing `flutter/keyboard` lifecycle: the engine now creates the channel and registers a handler just after the channel creation. In order to avoid regression, this PR also updates the channel implemenation (see `KeyboardChannel`) to return an empty `HashMap` when there is no handler registered. ## Related Issue Android engine implementation for flutter/flutter#87391 (see #42346 for Linux implementation) Fixes flutter/flutter#122441 ## Tests Adds 3 tests.
auto-submit bot pushed a commit that referenced this pull request
Jul 26, 2023## Description This PR updates the macOS engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue macOS engine implementation for flutter/flutter#87391 Similar to: - Linux: #42346 - Android: #42758 ## Tests Adds 2 tests.
bleroux
deleted the
linux_return_keyboard_pressed_state
branch
auto-submit bot pushed a commit that referenced this pull request
Aug 9, 2023## Description This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue Windows engine implementation for flutter/flutter#87391. Similar to: - Linux: #42346 - Android: #42758 - macOS: #42878 ## Tests Adds 2 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters