Make IfPipe#defaultMediaType more dynamic, add type TEXT by tnleeuw · Pull Request #10258 · frankframework/frankframework
Navigation Menu
{{ message }}
frankframework / frankframework Public
- Notifications You must be signed in to change notification settings
- Fork 81
Merged
Jan 13, 2026Conversation
Copy link Copy Markdown
Contributor
tnleeuw
commented
Jan 12, 2026
tnleeuw
commented
Changes
Pull Request Checklist
Title
- Title expresses the business value (who benefits + what outcome)
Issues
Backports
- Backport PRs created (if needed) and linked
Documentation
- FF! Doc updated (user-facing behavior/config)
- FF! Manual updated (if applicable)
- Javadoc updated/generated (developer-facing APIs)
Tests
- Unit tests added/updated
- E2E/Integration tests added/updated (if applicable)
Breaking changes
- Breaking change recorded in markdown file
- Migration notes included (if needed)
tnleeuw
requested review from
evandongen and
nielsm5
tnleeuw
self-assigned this
evandongen approved these changes Jan 13, 2026
Comment on lines +164 to +165
| TEXT(MediaType.TEXT_PLAIN) | ||
| ; |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| TEXT(MediaType.TEXT_PLAIN) | |
| ; | |
| TEXT(MediaType.TEXT_PLAIN); |
nielsm5 requested changes Jan 13, 2026
Comment on lines +406 to +407
| * @param defaultMediaType The default media type to use when the media type of the message could not be determined. Should | ||
| * be one of {@literal XML}, {@literal JSON} or {@literal TEXT}. |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De should be one of hoeft er niet in, dat komt automatisch omdat het een enum is.
core/src/main/java/org/frankframework/pipes/IfPipe.java
Show resolved
Hide resolved
core/src/main/java/org/frankframework/pipes/IfPipe.java Show resolved Hide resolved
tnleeuw added 3 commits
January 13, 2026 10:41
Copy link Copy Markdown
sonarqubecloud
bot
commented
Jan 13, 2026
sonarqubecloud bot commented
Jan 13, 2026
Quality Gate passed
Issues
Measures
nielsm5 approved these changes Jan 13, 2026
nielsm5
deleted the
issue/10254_IfPipe_DefaultSupportedMediaType
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants