Improve Dockerfile, and added alpine version by alexbrazier · Pull Request #623 · freeCodeCamp/devdocs
Navigation Menu
{{ message }}
freeCodeCamp / devdocs Public
- Notifications You must be signed in to change notification settings
- Fork 2.6k
Closed
alexbrazier wants to merge 4 commits intofreeCodeCamp:masterfrom
Closed
Improve Dockerfile, and added alpine version#623
alexbrazier wants to merge 4 commits intofreeCodeCamp:masterfrom
Improve Dockerfile, and added alpine version#623
alexbrazier wants to merge 4 commits intofreeCodeCamp:masterfrom
Conversation
Copy link
Contributor
alexbrazier
commented
May 8, 2017
alexbrazier
commented
- Added docker ignore to remove unnecessary files
- Reduce number of layers, and optimise build speed (e.g. don't re-download gem files on every file change)
- Add alpine version to reduce size
- By deleting
/tmpit reduces the size from ~4GB to ~2GB
Copy link
Contributor Author
alexbrazier
commented
May 8, 2017
alexbrazier commented
May 8, 2017@Thibaut Any chance you could also setup an automated build on https://hub.docker.com so that they are automatically updated when the code is changed?
flyudvik reviewed May 13, 2017
Dockerfile
Outdated
Dockerfile Outdated
|
|
||
| RUN apt-get update && \ | ||
| apt-get -y install git nodejs && \ | ||
| gem install bundler |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thibaut reviewed May 14, 2017
Dockerfile
Outdated
Dockerfile Outdated
| @@ -1,17 +1,23 @@ | |||
|
|
|||
| FROM ruby:2.4.1 | |||
| MAINTAINER Conor Heine <conor.heine@gmail.com> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Copy link
Member
Thibaut
commented
May 14, 2017
Thibaut commented
May 14, 2017Any chance you could also setup an automated build on https://hub.docker.com so that they are automatically updated when the code is changed?
I'll set that up next week-end.
Copy link
Contributor Author
alexbrazier
commented
May 15, 2017
alexbrazier commented
May 15, 2017@Thibaut Awesome
I've attached a screenshot of the config to build both the alpine image and the regular:

To setup the repo you just need to select create an automated build, link github and select the repo, then enter the config above

Copy link
Member
Thibaut
commented
May 21, 2017
Thibaut commented
May 21, 2017Done: 50ca8e2
https://hub.docker.com/r/devdocs/devdocs/
Thanks for the PR & instructions!
Thibaut
closed this
sudoexec
mentioned this pull request
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment