Add more event listener for Marker by yonasadiel · Pull Request #456 · fullstackreact/google-maps-react
Navigation Menu
{{ message }}
fullstackreact / google-maps-react Public
- Notifications You must be signed in to change notification settings
- Fork 807
Closed
yonasadiel wants to merge 1 commit intofullstackreact:masterfrom
yonasadiel:add-event-listener
Closed
Add more event listener for Marker#456
yonasadiel wants to merge 1 commit intofullstackreact:masterfrom
yonasadiel:add-event-listener
Add more event listener for Marker#456
yonasadiel wants to merge 1 commit intofullstackreact:masterfrom
yonasadiel:add-event-listener
Conversation
Copy link Copy Markdown
yonasadiel
commented
Jul 4, 2020
yonasadiel
commented
Based on this code, the Marker can accept some more event listener. However, only onClick and onMouseover are listed on typescript definition.
google-maps-react/src/components/Marker.js
Lines 97 to 104 in 5038ac4
| handleEvent(evt) { | |
| return (e) => { | |
| const evtName = `on${camelize(evt)}` | |
| if (this.props[evtName]) { | |
| this.props[evtName](this.props, this.marker, e); | |
| } | |
| } | |
| } |
Copy link Copy Markdown
Author
yonasadiel
commented
Jul 4, 2020
yonasadiel commented
Jul 4, 2020Ups, I think this is duplicate of #433
yonasadiel
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant