Report discarded log in batch processor as `log_byte` by adinauer · Pull Request #4971 · getsentry/sentry-java

Report discarded log in batch processor as `log_byte` by adinauer · Pull Request #4971 · getsentry/sentry-java

Skip to content

Conversation

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

		options
		.getClientReportRecorder()
		.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.Attachment, lostBytes);
		.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.LogByte, lostBytes);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a test for this

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	311.92 ms	352.76 ms	40.84 ms
Size	1.58 MiB	2.20 MiB	635.28 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`abfcc92`	309.54 ms	380.32 ms	70.78 ms
`fcec2f2`	357.47 ms	447.32 ms	89.85 ms
`bbc35bb`	298.53 ms	372.17 ms	73.64 ms
`ee747ae`	357.79 ms	421.84 ms	64.05 ms
`d15471f`	315.20 ms	370.22 ms	55.02 ms
`b77456b`	393.26 ms	441.10 ms	47.84 ms
`d15471f`	310.26 ms	377.04 ms	66.78 ms
`ee747ae`	386.94 ms	431.43 ms	44.49 ms
`fc5ccaf`	279.11 ms	353.34 ms	74.23 ms
`d15471f`	286.65 ms	314.68 ms	28.03 ms

App size

Revision	Plain	With Sentry	Diff
`abfcc92`	1.58 MiB	2.13 MiB	557.31 KiB
`fcec2f2`	1.58 MiB	2.12 MiB	551.50 KiB
`bbc35bb`	1.58 MiB	2.12 MiB	553.01 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`d15471f`	1.58 MiB	2.13 MiB	559.54 KiB
`b77456b`	1.58 MiB	2.12 MiB	548.11 KiB
`d15471f`	1.58 MiB	2.13 MiB	559.54 KiB
`ee747ae`	1.58 MiB	2.10 MiB	530.95 KiB
`fc5ccaf`	1.58 MiB	2.13 MiB	557.54 KiB
`d15471f`	1.58 MiB	2.13 MiB	559.54 KiB

Previous results on branch: adinauer-patch-1

Startup times

Revision	Plain	With Sentry	Diff
`07fdf4b`	311.86 ms	358.65 ms	46.79 ms
`da220b3`	310.69 ms	372.63 ms	61.95 ms

App size

Revision	Plain	With Sentry	Diff
`07fdf4b`	1.58 MiB	2.13 MiB	559.52 KiB
`da220b3`	1.58 MiB	2.20 MiB	633.89 KiB