fix(logs): Check `sendDefaultPii` before attaching user attributes by adinauer ยท Pull Request #5036 ยท getsentry/sentry-java
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 467
Conversation
๐ Description
Check sendDefaultPii before attaching user attributes to logs.
๐ก Motivation and Context
Fixes #4973
๐ How did you test it?
๐ Checklist
- I added GH Issue ID & Linear ID
- I added tests to verify the changes.
- No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - I updated the docs if needed.
- I updated the wizard if needed.
- Review from the native team if needed.
- No breaking change or entry added to the changelog.
- No breaking change for hybrid SDKs or communicated to hybrid SDKs.
๐ฎ Next steps
Semver Impact of This PR
๐ข Patch (bug fixes)
๐ Changelog Preview
This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).
New Features โจ
- Allow setting native SDK name in manifest by bitsandfoxes in
#5027
Bug Fixes ๐
- (logs) Check
sendDefaultPiibefore attaching user attributes by adinauer in#5036
Build / dependencies / internal ๐ง
Deps
- Bump JamesIves/github-pages-deploy-action from 4.7.6 to 4.8.0 by dependabot in
#5015 - Update Native SDK to v0.12.3 by github-actions in
#5012 - Bump github/codeql-action from 4.31.8 to 4.31.10 by dependabot in
#5032
Other
- (release) Switch from action-prepare-release to Craft by BYK in
#5014 - (repo) Add Claude Code settings with basic permissions by philipphofmann in
#5038
๐ค This preview updates automatically when you update the PR.
Performance metrics ๐
| Plain | With Sentry | Diff | |
|---|---|---|---|
| Startup time | 289.69 ms | 356.69 ms | 67.01 ms |
| Size | 1.58 MiB | 2.20 MiB | 635.37 KiB |
Baseline results on branch: main
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 375.27 ms | 415.68 ms | 40.41 ms |
| d15471f | 310.66 ms | 368.19 ms | 57.53 ms |
| 27d7cf8 | 309.43 ms | 364.27 ms | 54.85 ms |
| d15471f | 361.89 ms | 378.07 ms | 16.18 ms |
| 27d7cf8 | 314.17 ms | 347.00 ms | 32.83 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| 27d7cf8 | 306.76 ms | 366.66 ms | 59.90 ms |
| fc5ccaf | 322.49 ms | 405.25 ms | 82.76 ms |
| fcec2f2 | 311.35 ms | 384.94 ms | 73.59 ms |
| dba088c | 333.98 ms | 381.16 ms | 47.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.51 KiB |
| dba088c | 1.58 MiB | 2.13 MiB | 558.99 KiB |
Previous results on branch: fix/logs-user-attributes-send-default-pii
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aadf8be | 332.67 ms | 391.74 ms | 59.07 ms |
| 8d49dc9 | 334.17 ms | 401.94 ms | 67.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| aadf8be | 1.58 MiB | 2.20 MiB | 635.38 KiB |
| 8d49dc9 | 1.58 MiB | 2.20 MiB | 635.37 KiB |
adinauer
changed the title
feat(logs): Check
fix(logs): Check sendDefaultPii before attaching user attributessendDefaultPii before attaching user attributes
adinauer
deleted the
fix/logs-user-attributes-send-default-pii
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters