feat(crashpad): offline caching by jpnurmi · Pull Request #1493

feat(crashpad): offline caching by jpnurmi · Pull Request #1493 · getsentry/sentry-native

and others added 16 commits

January 23, 2026 14:21

Before "revert separate caching folder implementation"

#1461

Cast cache_max_age to time_t to avoid implicit signedness conversion
between uint64_t and time_t.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add explicit static_cast<time_t>() for cache_max_age to fix
-Wsign-conversion warning on Windows with clang-cl.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

This was referenced

Jan 26, 2026

For consistency with time-related operations throughout the codebase.

This adds a time.h dependency to the public header, but it's a
lightweight standard C header available since C89.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Subtract file size from accumulated_size when a file is pruned (by age
or size). Previously, pruned files' sizes were still counted, causing
subsequent valid files to be incorrectly pruned when both cache_max_age
and cache_max_size were set.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

jpnurmi marked this pull request as ready for review

February 10, 2026 09:32

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ted_reports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Base automatically changed from jpnurmi/feat/offline-caching to master

February 11, 2026 13:13

jpnurmi deleted the jpnurmi/feat/crashpad-offline-caching branch

February 11, 2026 18:01