Add parameter in function maybeGeneratePropertiesFile in order to choose to escape unicode or not. by gary258796 · Pull Request #11 · git-commit-id/git-commit-id-plugin-core
Navigation Menu
{{ message }}
git-commit-id / git-commit-id-plugin-core Public
- Notifications You must be signed in to change notification settings
- Fork 14
Conversation
Copy link Copy Markdown
Contributor
gary258796
commented
Oct 7, 2022
gary258796
commented
Context
By #10 , we need a parameter to set in order to not escape unicode if we want.
Contributor Checklist
- Added relevant integration or unit tests to verify the changes
- Update the Readme or any other documentation (including relevant Javadoc)
- Ensured that tests pass locally:
mvn clean package - Ensured that the code meets the current
checkstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B
…ape unicode or not.
TheSnoozer reviewed Oct 7, 2022
src/main/java/pl/project13/core/util/PropertyManager.java
Show resolved
Hide resolved
src/main/java/pl/project13/core/util/PropertyManager.java Show resolved Hide resolved
TheSnoozer
merged commit
cb3375a
into
git-commit-id:master
Copy link Copy Markdown
Contributor
TheSnoozer
commented
Oct 7, 2022
TheSnoozer commented
Oct 7, 2022Thanks for your investigation and contribution to the fix!
TheSnoozer
mentioned this pull request
TheSnoozer
added this to the
6.0.0 milestone
gary258796
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants