Ensure that the GitHubPaneViewModel is initalized. by grokys · Pull Request #1426 · github/VisualStudio
- Renamed `IGitHubToolWindowManager.ShowHomePane` to `ShowGitHubPane` because the latter is what we call it these days - Make `IGitHubToolWindowManager.ShowGitHubPane` async to make sure that `GitHubPaneViewModel.InitializeAsync` has finished before passing back a refrence to the `GitHubPaneViewModel` - Make the methods that call `IGitHubToolWindowManager.ShowGitHubPane` `void async` with logging when they fail
grokys
changed the title
Ensure that the GitHubPaneViewModel is initalized.
WIP: Ensure that the GitHubPaneViewModel is initalized.
When the GitHub pane is shown from VS rather than our own code, kick off an initialization of the view model. This means we can't be sure of the state of the view model's initialization so make subsequent calls to the view model async either wait for an ongoing initialization, or exit if already initialized.
grokys
changed the title
WIP: Ensure that the GitHubPaneViewModel is initalized.
Ensure that the GitHubPaneViewModel is initalized.
grokys
deleted the
fixes/githubpane-initialization
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters