Treat status reports as non-critical by jsoref · Pull Request #2121

Treat status reports as non-critical by jsoref · Pull Request #2121 · github/codeql-action

Resolve github/codeql#15462 (comment) by converting sendStatusReport into a function that always returns void and uses core.warning instead of core.error

Split from:

Document token input #2110

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Confirm the readme has been updated if necessary.
Confirm the changelog has been updated if necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this — our telemetry reporting should indeed be non-critical! I've just added a few comments.

I think this may warrant a CHANGELOG entry 🌞 users who may have seen this failure in the past should be happy to see the change.

This was referenced

Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I have a few copy-editing suggestions and one question about 404/403 errors.

		import { SarifFile, ConfigurationError, wrapError } from "./util";

		const GENERIC_403_MSG =
		"The repo on which this action is running has not opted-in to CodeQL code scanning.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message and the one below it needs some work, but as you mentioned, it is outside the scope of this PR.

Thanks again for your work on this.

Change `sendStatusReport` to `void`

Thanks again! Nice work here.

jsoref deleted the status-reports-are-not-critical branch

February 12, 2024 21:07

This was referenced

May 13, 2024

This was referenced

May 14, 2024