Add flag to customize the interval which the onStatus hook is called by tknodell-recurly · Pull Request #1083 · github/gh-ost

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tknodell-recurly

Copy link Copy Markdown

Contributor

A Pull Request should be associated with an Issue.

Related issue: #1082

Description

This PR adds a new flag hooks-status-interval which defaults to 60 seconds
Allows customization of how often the onStatus hook fires

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.
Copy link Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tknodell-recurly, this looks good - we'll include this in the next release 👍

@ghost ghost added this to the v1.1.4 milestone

Feb 7, 2022

@ghost ghost merged commit ebd5645 into github:master

Feb 7, 2022

This was referenced

Feb 7, 2022

@tknodell-recurly tknodell-recurly deleted the customize_status_hook_interval branch

February 7, 2022 20:03

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.4

Development

Successfully merging this pull request may close these issues.

1 participant

@tknodell-recurly