Add flag to customize the interval which the onStatus hook is called by tknodell-recurly · Pull Request #1083 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
2 commits merged intogithub:masterfrom
Feb 7, 2022Merged
Conversation
Copy link Copy Markdown
Contributor
tknodell-recurly
commented
Feb 1, 2022
tknodell-recurly
commented
A Pull Request should be associated with an Issue.
Related issue: #1082
Description
This PR adds a new flag hooks-status-interval which defaults to 60 seconds
Allows customization of how often the onStatus hook fires
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
ghost approved these changes Feb 7, 2022
Copy link Copy Markdown
ghost
left a comment
ghost
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tknodell-recurly, this looks good - we'll include this in the next release 👍
ghost
added this to the
v1.1.4 milestone
ghost
merged commit
ebd5645
into
github:master
tknodell-recurly
deleted the
customize_status_hook_interval
branch
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment