Fix `integer divide by zero` panic in migrator by timvaillancourt · Pull Request #1140 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
3 commits merged intogithub:masterfrom
Jul 6, 2022Merged
Fix integer divide by zero panic in migrator#1140
3 commits merged intogithub:masterfrom
Fix integer divide by zero panic in migrator#1140
3 commits merged intogithub:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
Related issue: #1117
Description
This PR resolves an integer divide by zero panic when migrationContext.HooksStatusIntervalSec is zero. After this PR, no status will be printed when the interval is set to zero
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
timvaillancourt
requested review from
a user and
rashiq
timvaillancourt
added
the
low-risk
label
timvaillancourt
added this to the
v1.1.5 milestone
rashiq approved these changes Jun 23, 2022
ghost approved these changes Jul 6, 2022
dm-2 added 2 commits
July 6, 2022 16:32
ghost
merged commit
3901a86
into
github:master
timvaillancourt
deleted the
fix-issue-1117
branch
ghost
mentioned this pull request
Closed
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment