Add basic tests for applier by timvaillancourt · Pull Request #1165 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
timvaillancourt merged 3 commits intogithub:masterfrom
Sep 6, 2022Merged
Add basic tests for applier#1165
timvaillancourt merged 3 commits intogithub:masterfrom
Add basic tests for applier#1165
timvaillancourt merged 3 commits intogithub:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
Description
This PR adds basic tests to a few funcs from go/logic/applier.go, also two small fixes were made based on findings in testing
Details:
- Added tests to func that don't use MySQL in
go/logic/applier_test.go - Removed extra spaces in
sql.BuildDMLUpdateQuery()fromgo/sql/builder.go - Modified
applier.generateSqlModeQuery()to avoid duplicate commas:- Before example (double-comma):
sql_mode = CONCAT(@@session.sql_mode, ',,NO_AUTO_VALUE_ON_ZERO')
- After example:
sql_mode = CONCAT(@@session.sql_mode, ',NO_AUTO_VALUE_ON_ZERO')
- Before example (double-comma):
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
timvaillancourt
added
the
low-risk
label
timvaillancourt
requested review from
a user and
rashiq
timvaillancourt
added this to the
v1.1.6 milestone
timvaillancourt
added
enhancement
build
labels
ghost approved these changes Sep 6, 2022
timvaillancourt
merged commit
1fa3d4f
into
github:master
timvaillancourt
deleted the
logic-applier-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment