Support to config charset and collation by shaohk · Pull Request #1368 · github/gh-ost

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shaohk

Copy link Copy Markdown

Contributor

@shaohk shaohk commented

Jan 18, 2024

Description

The ability to specify character set and collation is supported.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@shaohk shaohk requested a review from a user

January 18, 2024 02:54

@meiji163 meiji163 merged commit aa010a0 into github:master

Mar 12, 2024

@timvaillancourt timvaillancourt added this to the v1.1.7 milestone

Apr 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiji163 meiji163 meiji163 approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@shaohk @meiji163 @timvaillancourt