Fix successive failures error in streamer by timvaillancourt · Pull Request #1371 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
timvaillancourt merged 1 commit intogithub:masterfrom
Jan 23, 2024Merged
Fix successive failures error in streamer#1371
timvaillancourt merged 1 commit intogithub:masterfrom
Fix successive failures error in streamer#1371
timvaillancourt merged 1 commit intogithub:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
timvaillancourt
commented
Jan 22, 2024
timvaillancourt
commented
Related issue: #1370
Description
This PR fixes a conditional in go/logic/streamer.go so the specified max retries is respected
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
requested a review
from a user
timvaillancourt
requested review from
meiji163 and
rashiq
as code owners
timvaillancourt
added this to the
v1.1.7 milestone
timvaillancourt
added
bug
low-risk
labels
meiji163 approved these changes Jan 23, 2024
timvaillancourt
merged commit
11d66d8
into
github:master
timvaillancourt
deleted the
fix-streamer-maxRetries-err
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment