chore: fix function names in comment by mountcount · Pull Request #1405 · github/gh-ost

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mountcount

Copy link Copy Markdown

Contributor

@mountcount mountcount commented

Apr 9, 2024

edited

Loading

Description

fix function names in comment

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.
Signed-off-by: mountcount <cuimoman@outlook.com>
Copy link Copy Markdown

Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mountcount!

@timvaillancourt timvaillancourt added this to the v1.1.7 milestone

Apr 14, 2024

@timvaillancourt timvaillancourt merged commit 8d99e46 into github:master

Apr 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@meiji163 meiji163 Awaiting requested review from meiji163 meiji163 is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

v1.1.7

Development

Successfully merging this pull request may close these issues.

2 participants

@mountcount @timvaillancourt