Ensure `-attempt-instant-ddl` respects `-execute` flag by timvaillancourt · Pull Request #1440 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
timvaillancourt merged 1 commit intogithub:masterfrom
Aug 14, 2024Merged
Ensure -attempt-instant-ddl respects -execute flag#1440
timvaillancourt merged 1 commit intogithub:masterfrom
Ensure -attempt-instant-ddl respects -execute flag#1440
timvaillancourt merged 1 commit intogithub:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
Description
This PR partially addresses #1365 by ensuring the -attempt-online-ddl feature respects the -execute flag
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
added
the
bug
label
timvaillancourt
requested review from
meiji163 and
rashiq
as code owners
timvaillancourt
mentioned this pull request
meiji163 approved these changes Aug 14, 2024
YazanAlnasr approved these changes Aug 14, 2024
hakusaro approved these changes Aug 14, 2024
timvaillancourt
merged commit
1e1fbcb
into
github:master
timvaillancourt
deleted the
attempt-online-ddl-execute-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment