Tweak the testcontainers setup by arthurschreiber · Pull Request #1460 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
Conversation
Copy link Copy Markdown
Contributor
arthurschreiber
commented
Oct 22, 2024
arthurschreiber
commented
Description
This PR attempts to improve the testcontainers ergonomics.
- Added a new
SkipPortValidationon the migration context. This is only used internally and allows skipping the port validation, which is useful with MySQL containers running in docker with a randomly assigned "external" port.
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
arthurschreiber
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
meiji163 previously approved these changes Oct 23, 2024
arthurschreiber
dismissed
meiji163’s stale review
via
23e5ed6
arthurschreiber added 5 commits
October 23, 2024 09:06meiji163 previously approved these changes Oct 23, 2024
arthurschreiber added 2 commits
October 23, 2024 22:18
arthurschreiber
dismissed
meiji163’s stale review
via
b888b2d
arthurschreiber added 2 commits
October 24, 2024 21:34…/tweak-testcontainers
Kiran14330
mentioned this pull request
meiji163 added 2 commits
November 18, 2024 13:36meiji163 approved these changes Nov 18, 2024
meiji163
merged commit
42c0f08
into
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants