Move successful cleanup into func by pasha132 · Pull Request #1520 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
Move successful cleanup into func#1520
meiji163 merged 3 commits intogithub:masterfrom
pasha132:fix-instant-cleanup
Move successful cleanup into func#1520
meiji163 merged 3 commits intogithub:masterfrom
pasha132:fix-instant-cleanup
Conversation
Copy link Copy Markdown
Contributor
pasha132
commented
Mar 21, 2025
pasha132
commented
Related issue: #1510
Description
Trying to fix inconsistent behavior between instant and usual ways of migrating.
In case this PR introduced Go code changes:
- contributed code is using same conventions as original code
-
script/cibuildreturns with no formatting errors, build errors or unit test errors.
pasha132
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
pasha132 added 3 commits
April 4, 2025 13:57meiji163 approved these changes Apr 7, 2025
meiji163
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants