fix(applier): added support for unique text column, they are mapped to uint8[] by markmarkmarkthebest · Pull Request #1583 · github/gh-ost
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.4k
Merged
meiji163 merged 1 commit intogithub:masterfrom
Sep 22, 2025Merged
Conversation
Copy link Copy Markdown
Contributor
markmarkmarkthebest
commented
Sep 7, 2025
markmarkmarkthebest
commented
Related issue: #1582
Description
This PR changes the updateModifiesUniqueKeyColumns function in applier.go to use reflect.DeepEqual for value comparison to handle unique keys that are text fields because they are mapped to unit8[] slices.
markmarkmarkthebest
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
Copy link Copy Markdown
Contributor Author
markmarkmarkthebest
commented
Sep 7, 2025
markmarkmarkthebest commented
Sep 7, 2025I can check if the go type of the column is uint8[] first and handle that case specifically if needed
meiji163 approved these changes Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants