Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely by meiji163 · Pull Request #1594 · github/gh-ost

and others added 6 commits

August 6, 2025 13:29
Based on experience, if the writer database fails inbeetween the copy & cutover stages (e.g. during cutover pause), the heartbeat writes will fail and stop,
then leading to throttled state and an infinite loop of throttler.shouldThrottle().

Since this state is irrecoverable, make the heartbeat writer panic if retries are exhausted, so that the migration can fail and be restarted later.
* add sysbench localtest

* fix table name

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* ensure cleanup

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings

October 10, 2025 20:47

thesnowrose