Add support for go 1.25 by ggilder · Pull Request #1634

Add support for go 1.25 by ggilder · Pull Request #1634 · github/gh-ost

Related issue: #1629

Description

Adds support for go 1.25

ggilder marked this pull request as ready for review

March 2, 2026 17:39

Copilot AI review requested due to automatic review settings

March 2, 2026 17:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Go version detection logic in script/ensure-go-installed so that local/dev builds recognize Go 1.25 as a supported version (addressing issue #1629 around go1.25.x not matching the script’s regex).

Changes:

Extend the supported Go version regex to include Go 1.25.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


		PREFERRED_GO_VERSION=go1.23.0
		SUPPORTED_GO_VERSIONS='go1.2[01234]'
		SUPPORTED_GO_VERSIONS='go1.2[012345]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPPORTED_GO_VERSIONS is used as a regex with grep, but the . characters in go1.2… are currently unescaped, so they match any character (not a literal dot). Consider tightening the pattern (e.g., escaping dots and optionally anchoring to go version output) and using grep -Eq for clarity/intent.

Copilot uses AI. Check for mistakes.

FWIW I have run script/cibuild and localtests/test.sh under go 1.25 (on macOS) and all the tests pass (except for the sysbench performance tests, ran into some unrelated setup issues with sysbench on macOS). However, it looks like CI only runs with the version set in go.mod (1.23). Let me know if you think that should be updated to 1.25; we could also change the workflow to use a matrix of go versions.