more DML tests for latin1 by shlomi-noach · Pull Request #291 · github/gh-ost

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shlomi-noach

Copy link Copy Markdown

Contributor

Storyline: #290

This PR adds update, delete to latin1 tests in an attempt to reproduce #290 , but the tests do not fail.

@shlomi-noach shlomi-noach merged commit 3435539 into master

Nov 1, 2016

@shlomi-noach shlomi-noach deleted the more-charset-tests branch

November 1, 2016 11:22

@MrMauricioLeite

Copy link Copy Markdown

This test do not cover TEXT columns. I'm having no trouble with VARCHAR columns but on TEXT columns I'm experiencing the same charset errors other were facing with varchar columns.

Does it make any sense?

@shlomi-noach

Copy link Copy Markdown

Contributor Author

I'll add tests for TEXT columns as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shlomi-noach @MrMauricioLeite