Support --mysql-timeout flag by shlomi-noach · Pull Request #824 · github/gh-ost

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shlomi-noach

Copy link Copy Markdown

Contributor

Looking into #822

This PR adds --mysql-timeout=<float> flag, which controls all these at once:

  • MySQL connect timeout (cap on establishing connection)
  • MySQL read timeout (cap on read query time)
  • MySQL write timeout (cap on write query time).
Copy link Copy Markdown

@evitame78 evitame78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@timvaillancourt timvaillancourt had a problem deploying to production/mysql_role=ghost_testing

August 19, 2020 19:37

Failure

@timvaillancourt timvaillancourt merged commit 720182f into master

Aug 19, 2020

@timvaillancourt timvaillancourt deleted the connection-timeout branch

August 19, 2020 19:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

+1 more reviewer

@evitame78 evitame78 evitame78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomi-noach @timvaillancourt @evitame78