Home Original page

Add 'applier' and 'inspector' commands to server by timvaillancourt · Pull Request #951 · github/gh-ost

@timvaillancourt

Description

This PR introduces two new commands for the unix-socket/TCP server:

  1. applier - list the MySQL hostname of the applier
  2. inspector - list the MySQL hostname of the inspector

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

cc @gtowey / @TeeKraken / @shlomi-noach

@timvaillancourt timvaillancourt changed the title Add server cmd hosts Add 'applier' and 'inspector' commands to server

Apr 2, 2021

@timvaillancourt

rashiq

gtowey

shlomi-noach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timvaillancourt

@timvaillancourt

@timvaillancourt

Example output w/applier+inspector on same host:

tim@Tims-MacBook-Pro /tmp % echo applier | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log
tim@Tims-MacBook-Pro /tmp % echo inspector | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log

That's the final tweak before merging