add options param to `listIssueComments` to get pagination result by bambooom · Pull Request #399 · github-tools/github

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Open

bambooom wants to merge 1 commit intogithub-tools:masterfrom

bambooom:master

Conversation

@bambooom

Copy link Copy Markdown

as I found that _requestAllPages will be deprecated, so I just add options to _request method to solve the problem I met in #398. 😊

metaodi reacted with thumbs up emoji

@metaodi

Copy link Copy Markdown

metaodi commented

Jun 20, 2017

To have an options parameter is great, this would make it possible to pass the since parameter, to only get a subset of all comments.

@j-rewerts j-rewerts mentioned this pull request

Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zardashtsyber zardashtsyber zardashtsyber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bambooom @metaodi @zardashtsyber