Home Original page

feature(repository): add listPullRequestReviews by SimonBarendse · Pull Request #454 · github-tools/github

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@SimonBarendse

Copy link Copy Markdown

resolves #453

Copy link Copy Markdown

Member

@mtscout6 mtscout6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this

@SimonBarendse SimonBarendse force-pushed the 453_list_pull_request_reviews branch 3 times, most recently from 16724f5 to c73059a Compare

September 3, 2017 22:35

@SimonBarendse SimonBarendse force-pushed the 453_list_pull_request_reviews branch from c73059a to 3f9e5a2 Compare

September 3, 2017 23:27

@SimonBarendse SimonBarendse changed the title Add listPullRequestReviews method to Repostitory class feature(repository): add listPullRequestReviews

Sep 3, 2017

@SimonBarendse

Copy link Copy Markdown

Author

@mtscout6 I've added a test.

@esbanarango

Copy link Copy Markdown

@mtscout6 @SimonBarendse Anything in particular tat prevents this PR to be merged?

@j-rewerts

Copy link Copy Markdown

Member

I think we've got to get this pointed to an actual test repository that has test reviews on it. @SimonBarendse Could you switch to using the test user for your test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtscout6 mtscout6 mtscout6 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List reviews on a Pull Request

4 participants

@SimonBarendse @esbanarango @j-rewerts @mtscout6