Home Original page

Add add label to an issue by asmsuechan · Pull Request #461 · github-tools/github

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@asmsuechan

Copy link Copy Markdown

I could not find these methods so I created. If anyone has any information about them, please let me know.

@asmsuechan asmsuechan force-pushed the add-add-label-to-an-issue branch from 4fbc7bd to 81706ba Compare

July 11, 2017 12:32
Copy link Copy Markdown

Member

@mtscout6 mtscout6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for these.

@asmsuechan

Copy link Copy Markdown

Author

Sure

@j-rewerts

Copy link Copy Markdown

Member

@clayreimann This API is marked as preview by GitHub. What is the policy on using preview APIs?

@clayreimann

Copy link Copy Markdown

Member

@j-rewerts it's unclear. I guess we could mark the API as provisional in this library and let clients assume the risks

@j-rewerts

Copy link Copy Markdown

Member

Yeah that's a good idea. I'll take this code and write tests for them when I have a second. I've added an issue here for going through the code base and adding warnings like this.

@clayreimann

Copy link Copy Markdown

Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtscout6 mtscout6 mtscout6 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asmsuechan @j-rewerts @clayreimann @mtscout6