WIP: Search paging by j-rewerts · Pull Request #596 · github-tools/github

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@j-rewerts

Copy link Copy Markdown

Member

Added optional manual paging of search. Closes #562.

@j-rewerts

Copy link Copy Markdown

Member Author

@DanielRuf I'm running into some issue with Nock I just can't seem to sort out. When I run the search tests on their own, my new test passes. If I run all tests using npm run test, my new test fails. Any idea why this may be happening?

@j-rewerts j-rewerts requested a review from DanielRuf

October 30, 2019 18:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielRuf DanielRuf Awaiting requested review from DanielRuf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

could it be pageable for searching

1 participant

@j-rewerts