Fix missing stderr when the progress parameter of _clone is None by liangjingyang · Pull Request #1224 · gitpython-developers/GitPython
Conversation
Try to fix #1221
The to_progress_instance function will convert None to RemoteProgress instance, so the line if progress_checked is True if progress parameter is None.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).
Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).
Are you able to push it into this PR? If not I would be happy to do that for you if you post it here.
Once approved by @muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not).
Byron
mentioned this pull request
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters