Ask git where its daemon is and use that by EliahKagan · Pull Request #1697

Ask git where its daemon is and use that by EliahKagan · Pull Request #1697 · gitpython-developers/GitPython

This changes the test helpers on Windows to use "git --exec-path"
(with whatever "git" GitPython is using) to find the directory that
contains "git-daemon.exe", instead of finding it in a PATH search.

renovate bot referenced this pull request in allenporter/flux-local

Oct 20, 2023

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request

Oct 24, 2023

This removes the Windows-specific information in the warning
message in git_daemon_launched.

After the associated functionality was updated in gitpython-developers#1684 and the
warning message was abridged accordingly, the functionality was
updated again in gitpython-developers#1697, causing the message to be outdated and no
longer helpeful (since having git-daemon.exe in a PATH directory is
no longer necessary or useful), without any corresponding change to
the message.

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request

Oct 24, 2023

This removes the Windows-specific information in the warning
message in git_daemon_launched.

After the associated functionality was updated in gitpython-developers#1684 and the
warning message was abridged accordingly, the functionality was
updated again in gitpython-developers#1697, causing the message to be outdated and no
longer helpeful (since having git-daemon.exe in a PATH directory is
no longer necessary or useful), without any corresponding change to
the message.

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request

Oct 24, 2023

This removes the Windows-specific information in the warning
message in git_daemon_launched.

After the associated functionality was updated in gitpython-developers#1684 and the
warning message was abridged accordingly, the functionality was
updated again in gitpython-developers#1697, causing the message to be outdated and no
longer helpeful (since having git-daemon.exe in a PATH directory is
no longer necessary or useful), without any corresponding change to
the message.