Remove git.util.NullHandler by EliahKagan · Pull Request #1807 · gitpython-developers/GitPython

added 2 commits

January 23, 2024 18:17
The NullHandler class in git.util was added when merging gitpython-developers#300, to
allow a noop handler to be used on Python 2.6, since the standard
library logging.NullHandler class was added in Python 2.7.

When introduced in d1a9a23, the git.util.NullHandler class was also
patched into the logging module, but that has no longer been done
since 2fced2e (gitpython-developers#979), nor does GitPython make other use of it.

This also changes the parameter type annotation on the emit method
from `object` to `logging.LogRecord`, which is the expeced type.
git.util has an __all__ attribute, which does not list NullHandler.
As NullHandler is not otherwise documented to be public, removing
it is not a breaking change, and there is no need for a deprecation
period or to wait until the next major version of GitPython.

See 741dfd3 for information about its history.

lettuce-bot bot referenced this pull request in lettuce-financial/github-bot-signed-commit

Feb 15, 2024

renovate bot referenced this pull request in allenporter/flux-local

Feb 16, 2024