remove type assertions from util.py by gcmarx · Pull Request #2028 · gitpython-developers/GitPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gcmarx

Copy link

Contributor

@gcmarx gcmarx commented

May 22, 2025

Fixes #1552

Copy link

Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

This looks like it was the preferred solution even though there are rightful concerns that this may break expectations of downstream code.

@Byron Byron merged commit bf51609 into gitpython-developers:main

May 23, 2025

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Byron Byron Byron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't use assert to enforce interface constraints

2 participants

@gcmarx @Byron