Implementation of TUI for Search using Bubbletea by scalvert · Pull Request #5 · gleanwork/glean-cli
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 0
Conversation
Summary
Migrates the glean search ... to use a TUI using Bubbletea.
New Search Functionality:
pkg/search/base_view.go: Added a newBaseSearchModelwith methods for performing searches, loading more results, and displaying error and loading views.pkg/search/default_view.go: Introduced asearchDisplayModelfor non-interactive search displays, including initialization, update, and view methods.pkg/search/common.go: Created common search utilities, including result item structures, list creation and updating functions, and search execution logic.
Code Refactoring:
cmd/chat.go: RefactoredformatReadingStagefunction to useutils.FormatDatasourceinstead of the localformatDatasourcefunction.
Dependency Updates:
go.mod: Updated the Go version and added several new dependencies, includingbubbles,bubbletea,lipgloss, and others.
Removal of Redundant Code:
cmd/search_test.go: Removed the entire file, including all test cases for the search command.
Import Adjustments:
cmd/chat.go: Added a new import forgithub.com/scalvert/glean-cli/pkg/utils.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 13 changed files in this pull request and generated 2 comments.
Files not reviewed (5)
- go.mod: Language not supported
- cmd/search_test.go: Evaluated as low risk
- cmd/chat.go: Evaluated as low risk
- pkg/search/models.go: Evaluated as low risk
- pkg/theme/theme.go: Evaluated as low risk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters