Rename TRUE and FALSE by keith · Pull Request #134 · google/cel-cpp
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 70
Merged
TristonianJones merged 2 commits intogoogle:masterfrom
keith:ks/rename-true-and-false
Nov 8, 2021Merged
TristonianJones merged 2 commits intogoogle:masterfrom
keith:ks/rename-true-and-false
TristonianJones merged 2 commits intogoogle:masterfrom
keith:ks/rename-true-and-false
Conversation
Copy link Copy Markdown
Contributor
keith
commented
Nov 6, 2021
keith
commented
This avoids conflicts with default macros defined by the Windows and
macOS SDKs.
Fixes: #121
This avoids conflicts with default macros defined by the Windows and macOS SDKs. Fixes: #121
keith
mentioned this pull request
Copy link Copy Markdown
Contributor Author
keith
commented
Nov 6, 2021
keith commented
Nov 6, 2021I have no idea if changing this is safe in general, but here's a potential solution to the linked issue
parser/Cel.g4
Outdated
Show resolved
Hide resolved
parser/Cel.g4 Outdated Show resolved Hide resolved
keith
requested a review
from TristonianJones
TristonianJones approved these changes Nov 8, 2021
Copy link Copy Markdown
Collaborator
TristonianJones
commented
Nov 8, 2021
TristonianJones commented
Nov 8, 2021I ran tests internally and all is well with this change.
TristonianJones
merged commit
60c7aea
into
google:master
Copy link Copy Markdown
Contributor Author
keith
commented
Nov 8, 2021
keith commented
Nov 8, 2021thanks!
keith
deleted the
ks/rename-true-and-false
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment